Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce {Max,Min}ByNaturalOrder Refaster rules #970

Merged
merged 1 commit into from
Jan 16, 2024
Merged

Introduce {Max,Min}ByNaturalOrder Refaster rules #970

merged 1 commit into from
Jan 16, 2024

Conversation

Stephan202
Copy link
Member

@Stephan202 Stephan202 commented Jan 13, 2024 •
edited
Loading

Suggested commit message:

Introduce `{Max,Min}ByNaturalOrder` Refaster rules (#970)

@Stephan202 Stephan202 added this to the 0.15.0 milestone Jan 13, 2024
@github-actions GitHub Actions
Copy link

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

mohamedsamehsalah
mohamedsamehsalah approved these changes Jan 13, 2024
View reviewed changes
Copy link
Contributor

@mohamedsamehsalah mohamedsamehsalah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean 🧹

@Stephan202 Stephan202 force-pushed the sschroevers/introduce-min-max-by-natural-order-rules branch from 910e126 to e0c28c3 Compare January 13, 2024 20:23
Venorcis
Venorcis approved these changes Jan 16, 2024
View reviewed changes
Copy link
Contributor

@Venorcis Venorcis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

@rickie rickie force-pushed the sschroevers/introduce-min-max-by-natural-order-rules branch from e0c28c3 to 477f619 Compare January 16, 2024 10:52
@github-actions GitHub Actions
Copy link

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@rickie rickie merged commit 51317fb into master Jan 16, 2024
16 checks passed
@rickie rickie deleted the sschroevers/introduce-min-max-by-natural-order-rules branch January 16, 2024 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mohamedsamehsalah mohamedsamehsalah mohamedsamehsalah approved these changes

@rickie rickie rickie approved these changes

@Venorcis Venorcis Venorcis approved these changes

Assignees
No one assigned
Labels
new feature
Milestone
0.15.0
Development

Successfully merging this pull request may close these issues.
4 participants
@Stephan202 @Venorcis @rickie @mohamedsamehsalah